Skip to content

Fix model search being prefilled on dropdown #5449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mrubens merged 2 commits into from
Jul 7, 2025
Merged

Fix model search being prefilled on dropdown #5449

mrubens merged 2 commits into from
Jul 7, 2025

Conversation

@kevinvandijk
Copy link
Contributor

@kevinvandijk kevinvandijk commented Jul 7, 2025 •
edited by ellipsis-dev bot
Loading

Hi Roo Team! At Kilo Code we got this small QoL request and fixed it on our side so we thought this might be useful to you too!

We've seen it come by on our Discord quite often as an annoyance so hopefully this is helpful to you too.

This prevents the search from opening like this:
image

and instead makes it open like this, which is much more logical and less confusing:
image

Test Procedure

  • Open de model selector dropdown when you have a model selected and see that it's not prefilled but focused
  • Fill in some search term, close the selector, re-open and see that it's not prefilled but focused

Type of Change

  • 🐛 Bug Fix: Non-breaking change that fixes a usability issue.

Important

Fix ModelPicker to not prefill search input with selected model ID when dropdown opens, focusing with an empty value instead.

  • Behavior:
    • ModelPicker no longer pre-fills search input with selected model ID when dropdown opens.
    • Search input is focused with an empty value instead.
  • Functions:
    • useState for searchValue initialized to empty string in ModelPicker.
    • onSelect and onOpenChange callbacks updated to clear searchValue on close.
  • Misc:
    • Removed unnecessary timeout logic for setting searchValue to selected model ID.

This description was created by Ellipsis for 91d523e. You can customize this summary. It will automatically update as commits are pushed.

@kevinvandijk kevinvandijk requested review from cte, jr and mrubens as code owners July 7, 2025 15:42
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. bug Something isn't working labels Jul 7, 2025
mrubens
mrubens approved these changes Jul 7, 2025
View reviewed changes
Copy link
Collaborator

@mrubens mrubens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh yeah, thank you!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 7, 2025
@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Jul 7, 2025
@mrubens mrubens merged commit 36b3cdc into RooCodeInc:main Jul 7, 2025
13 checks passed
@github-project-automation github-project-automation bot moved this from Triage to Done in Roo Code Roadmap Jul 7, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Jul 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrubens mrubens mrubens approved these changes

@cte cte Awaiting requested review from cte cte is a code owner

@jr jr Awaiting requested review from jr jr is a code owner

Assignees

No one assigned

Labels

bug Something isn't working Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.

Projects

Roo Code Roadmap
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kevinvandijk @mrubens @hannesrudolph